Origin link ID storage fix

[uruwhy]

Description

Since link IDs are now UUID strings, we will change the agent's origin_link_id field to be stored as a string rather than as an integer.

This will help address origin link ID issues in #2162

Requires mitre/gocat#59

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Updated and ran tests.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[github-actions]

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codecov]

Codecov Report

Merging #2187 (b4628bf) into master (a3532c2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2187   +/-   ##
=======================================
  Coverage   72.62%   72.62%           
=======================================
  Files         110      110           
  Lines        7942     7942           
=======================================
  Hits         5768     5768           
  Misses       2174     2174           

Impacted Files	Coverage Δ
app/objects/c_agent.py	90.31% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3532c2...b4628bf. Read the comment docs.

[bleepbop]

I'm getting an error when running a 54ndc47 agent. Seems like the instantiated agent still has origin_link_id as an int, because in the project logs I'm getting an ERROR (contact_http.py:40 _beacon) Malformed beacon: {'origin_link_id': ['Not a valid string.']}. HTML/TCP agents are working though

[uruwhy]

I'm getting an error when running a 54ndc47 agent. Seems like the instantiated agent still has origin_link_id as an int, because in the project logs I'm getting an ERROR (contact_http.py:40 _beacon) Malformed beacon: {'origin_link_id': ['Not a valid string.']}. HTML/TCP agents are working though

You'll need to make sure your gocat repo is using the branch from mitre/gocat#59 - unfortunately, I had to make changes to both the core platform code and the agent code itself. @bleepbop

[bleepbop]

I'm getting an error when running a 54ndc47 agent. Seems like the instantiated agent still has origin_link_id as an int, because in the project logs I'm getting an ERROR (contact_http.py:40 _beacon) Malformed beacon: {'origin_link_id': ['Not a valid string.']}. HTML/TCP agents are working though

You'll need to make sure your gocat repo is using the branch from mitre/gocat#59 - unfortunately, I had to make changes to both the core platform code and the agent code itself. @bleepbop

Sorry, missed that before. Looks good to me!

[mchan143]

This looks good to me. I think an update to the documentation regarding Lateral Movement Tracking should probably have a note about origin_link_id being a string instead.

[uruwhy]

This looks good to me. I think an update to the documentation regarding Lateral Movement Tracking should probably have a note about origin_link_id being a string instead.

Good idea - I'll make a PR for fieldmanual