Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VIRTS-2879] Plugins v2 API Pytests #2300

Merged
merged 16 commits into from Oct 13, 2021
Merged

[VIRTS-2879] Plugins v2 API Pytests #2300

merged 16 commits into from Oct 13, 2021

Conversation

bleepbop
Copy link
Contributor

@bleepbop bleepbop commented Oct 4, 2021

Description

Pytests for v2 Plugins API.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Verified tests pass for multiple versions of python using tox.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [NA] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@codecov
Copy link

codecov bot commented Oct 4, 2021 •
edited

Codecov Report

Merging #2300 (ee72acd) into master (4da3bdc) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2300      +/-   ##
==========================================
+ Coverage   72.57%   72.62%   +0.05%     
==========================================
  Files         109      110       +1     
  Lines        7916     7942      +26     
==========================================
+ Hits         5745     5768      +23     
- Misses       2171     2174       +3
Impacted Files Coverage Δ
app/service/file_svc.py 62.44% <0.00%> (-1.41%) ⬇️
app/api/v2/handlers/plugins_api.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da3bdc...ee72acd. Read the comment docs.

uruwhy
uruwhy previously approved these changes Oct 5, 2021
View reviewed changes
@bleepbop bleepbop requested a review from uruwhy October 6, 2021 17:41
@bleepbop bleepbop enabled auto-merge (squash) October 7, 2021 01:30
uruwhy
uruwhy previously approved these changes Oct 7, 2021
View reviewed changes
@bleepbop bleepbop requested a review from uruwhy October 7, 2021 16:20
uruwhy
uruwhy previously approved these changes Oct 7, 2021
View reviewed changes
@bleepbop bleepbop requested a review from uruwhy October 13, 2021 12:13
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bleepbop bleepbop merged commit a3532c2 into master Oct 13, 2021
@bleepbop bleepbop deleted the bleepbop/VIRTS-2879/plugins-api-v2-pytests branch October 13, 2021 13:59
cyber-arsenull pushed a commit that referenced this pull request Dec 28, 2021
@bleepbop
[VIRTS-2879] Plugins v2 API Pytests (#2300)
4921373 
* add pytests for plugins api

* remove unnecessary plugins from test api server

* resolve error in health tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbooth wbooth wbooth approved these changes

@uruwhy uruwhy uruwhy approved these changes

@kaylakraines kaylakraines Awaiting requested review from kaylakraines

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bleepbop @wbooth @uruwhy