New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Copy button for agent commands #2336
Conversation
Won't work if not on https or localhost, so just hide the button.
Codecov Report
@@ Coverage Diff @@
## master #2336 +/- ##
==========================================
+ Coverage 72.43% 72.60% +0.16%
==========================================
Files 110 110
Lines 7937 7946 +9
==========================================
+ Hits 5749 5769 +20
+ Misses 2188 2177 -11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with localhost vs http://--LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as intended!
Kudos, SonarCloud Quality Gate passed! |
Won't work if not on https or localhost, so just hide the button.
Description
The button wouldn't work if not on https or localhost, so just hide the button. The alternative fix would be to use a deprecated feature.
Fixes #2330
Type of change
How Has This Been Tested?
Replicated bug in Chrome, tested fix in Chrome and verified button still shows up when using localhost.
Checklist: