Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Copy button for agent commands #2336

Merged
merged 4 commits into from Nov 2, 2021
Merged

Fix Copy button for agent commands #2336

merged 4 commits into from Nov 2, 2021

Conversation

clenk
Copy link
Contributor

@clenk clenk commented Oct 26, 2021

Description

The button wouldn't work if not on https or localhost, so just hide the button. The alternative fix would be to use a deprecated feature.
Fixes #2330

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Replicated bug in Chrome, tested fix in Chrome and verified button still shows up when using localhost.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

Won't work if not on https or localhost, so just hide the button.
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #2336 (08510df) into master (0649166) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2336      +/-   ##
==========================================
+ Coverage   72.43%   72.60%   +0.16%     
==========================================
  Files         110      110              
  Lines        7937     7946       +9     
==========================================
+ Hits         5749     5769      +20     
+ Misses       2188     2177      -11     
Impacted Files Coverage Δ
app/service/app_svc.py 50.86% <0.00%> (-0.90%) ⬇️
app/service/file_svc.py 62.44% <0.00%> (-0.30%) ⬇️
app/contacts/contact_slack.py 34.09% <0.00%> (-0.16%) ⬇️
app/contacts/contact_tcp.py 46.31% <0.00%> (+0.07%) ⬆️
app/service/planning_svc.py 84.44% <0.00%> (+0.11%) ⬆️
app/contacts/contact_gist.py 50.76% <0.00%> (+8.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0649166...08510df. Read the comment docs.

Copy link
Contributor

@iguannalin iguannalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with localhost vs http://--LGTM!

Copy link
Contributor

@argaudreau argaudreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended!

@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@clenk clenk merged commit 3ba436e into master Nov 2, 2021
@clenk clenk deleted the fix-copy-btn branch November 2, 2021 13:37
cyber-arsenull pushed a commit that referenced this pull request Dec 28, 2021
Won't work if not on https or localhost, so just hide the button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser block copyCommondToClipboard if not behind HTTPS
4 participants