Handle Undefined Ability in Adversary Profile #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 6, 2022 12:54
ZacharyLPalmer
requested review from
argaudreau,
iguannalin,
mshkolnik22 and
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Kudos, SonarCloud Quality Gate passed!
|
argaudreau
suggested changes
May 16, 2022
There was a problem hiding this comment.
Clean code and clean interface -- great work! The feature itself works well, just a couple of minor comments. There are also a couple of console errors that pop up when I load the "Advanced Thief" adversary:
Those functions likely just need a catch for if a property is undefined since they don'
t affect how the page works.
argaudreau
previously approved these changes
May 19, 2022
ZacharyLPalmer
force-pushed
the
handle-missing-ability
branch
from
2db8783
to
6b3ad60
Compare
argaudreau
approved these changes
May 25, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
JamieScottC
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously an "undefined ability" (An ability ID in the atomic ordering the .yml file that does not map to a known ability) would cause the UI to lock up and require a page reload. This PR resolves that lock up and adds a series of UI indicators to inform the user of the problem. Specifically a Icon and error message appears at the bottom of the Ability table. Also the undefined abilities are highlighted in red and call out the unknown Ability ID from the .yml file. This change also involved changing the look of the "unmet requirements" call out from a red outline to a orange outline to better fit the icons in use.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I added multiple "bogus" Ability IDs in the .yml file (data/adversaries/ade13716-230a-48ea-a9b6-2446c83fe716.yml) and verified that they locked up the page before. After my fix I verified that they no longer lock up the page or cause any unexpected behavior to occur.
Checklist:
Screenshots of new callouts:
Undefined Ability and Unmet Requirements:
Undefined Ability:
