Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unreadable log messages referencing to abliity_id #2642

Merged
merged 3 commits into from
Sep 17, 2022

Conversation

Morpheme777
Copy link
Contributor

@Morpheme777 Morpheme777 commented Aug 15, 2022

We get the string <built-in function id> instead of real ability_id like 30cfed4036baf152888affdcd814312c.

Description

image
We get the string <built-in function id> instead of 30cfed4036baf152888affdcd814312c

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • place an ability .yml file to the folder with invalid tactic name (where 'tactic' inside the .yml file not equal folder name)
  • look at log file, a error ERROR (data_svc.py:168 load_ability_file) Ability=30cfed4036baf152888affdcd814312c looks correct

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

References

Issue #2640

We get the string <built-in function id> instead of real ability_id like '30cfed4036baf152888affdcd814312c'.
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested before and after this fix and confirmed it works as intended. Tests are failing because it comes from a fork (should not prevent merging).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants