Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoscrolling to operations page #2773

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Conversation

JamieScottC
Copy link
Contributor

@JamieScottC JamieScottC commented Jun 19, 2023

Description

This PR adds an autoscrolling feature to the operations page. When a new link is added to an operation, the window will automatically scroll down to put it into view. I also added a toggle in the top right to enable or disable the autoscrolling functionality, but if we don't think it's needed I can remove it.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I tested by starting new operations and waiting for links to be added, adding links using "manual command", and adding links using the "add potential links" function. In all three cases the window would scroll down to put them in view.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@JamieScottC JamieScottC marked this pull request as ready for review June 19, 2023 14:34
@clenk clenk self-requested a review June 19, 2023 17:56
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elegantmoose elegantmoose merged commit f2ddfa5 into master Jun 23, 2023
12 checks passed
@elegantmoose elegantmoose deleted the operation-autoscroll branch June 23, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants