Dockerfile Updates for Emu

[bleepbop]

Description

Users were running into InvalidToken cryptography errors when running the platform with Docker. This was due to the following scenario:

• The platform was started and stopped locally first (without Docker). This created an encrypted local backup.
• Users then tried to run the app with the Dockerfile, which does not run CALDERA with any flags in the Dockerfile. So the app would attempt to start with an existing local.yml file and a backup, should they exist.
• The original Dockerfile rewrote local.yml and its encryption keys used to load previous saves of the platform, writing a copy of default.yml into local.yml. The correct encryption keys from the original local.yml were overwritten, and the platform was unable to load previously saved data, ending execution with an InvalidToken error.

The Dockerfile has been updated to account for an existing local.yml file, and will make the necessary edits to that file as an opposed to overwriting it entirely. If a local.yml file is missing, a new one will be generated from default.yml, but with randomly set encryption/passwords (similarly to how the server normally creates that file).

Additionally, the Dockerfile has been updated to conditionally run necessary Emu installations if the Emu plugin is enabled.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• This change requires a documentation update

How Has This Been Tested?

Used this branch to rerun steps that produced error on master:

1. Ran server with --fresh. Shut down the server.
2. Built Docker Image (docker build . --build-arg WIN_BUILD=true -t caldera:latest).
3. Ran Docker Image (docker run -p 8888:8888 caldera:latest).

The server was verified to start successfully, with the Emu plugin loaded.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[sonarcloud]

Please retry analysis of this Pull-Request directly on SonarCloud.

[sonarcloud]

Please retry analysis of this Pull-Request directly on SonarCloud.

[elegantmoose]

LGTM

[clenk]

If conf/local.yml is used, this won't install the emu dependencies/download payloads. Maybe update it to create local.yml if it doesn't exist (similar to how it did previously), and then when checking if emu is enabled, it only has to check local.yml and not both.

Also when I ran this with docker-compose, when downloading the emu payloads I got the error "No such file or directory." The working directory for that command might be thrown off. Did you run into this?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[bleepbop]

If conf/local.yml is used, this won't install the emu dependencies/download payloads. Maybe update it to create local.yml if it doesn't exist (similar to how it did previously), and then when checking if emu is enabled, it only has to check local.yml and not both.

Also when I ran this with docker-compose, when downloading the emu payloads I got the error "No such file or directory." The working directory for that command might be thrown off. Did you run into this?

@clenk That makes sense. If we are using the default.yml to create our new local.yml, will there be any security issues with that? Technically this would be no different than running with --insecure even though we are not using that flag, because we are just using the encryption key from default.yml.

The script has been updated to fix the directory issue as well, that was just a matter of updating the WORKDIR.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sonarcloud]

Please retry analysis of this Pull-Request directly on SonarCloud.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information