Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes #29

Merged
merged 1 commit into from
Feb 21, 2021
Merged

Conversation

xtreme-nitin-ravindran
Copy link
Contributor

  • V-75445: locking root password by passwd -l root set paasowrd to !*.
# grep root /etc/shadow
root:!*:18472:0:99999:7:::
  • V-75529: Remove extra \s around true
# ruby -e 'puts /^\s*([^\s]*::Remove-Unused-Dependencies)\s*\\"true\\"\s*;$/.match("Unattended-Upgrade::Remove-Unused-Dependencies \"true\"")'

# ruby -e 'puts /^\s*([^\s]*::Remove-Unused-Dependencies)\s*\"true\"\s*;$/.match("Unattended-Upgrade::Remove-Unused-Dependencies \"true\";")'
Unattended-Upgrade::Remove-Unused-Dependencies "true";
  • V-75789: Path to pam_timestamp_check is /usr/sbin/pam_timestamp_check
# which pam_timestamp_check
/usr/sbin/pam_timestamp_check
  • V-75797: Rule should check for telnetd instead of telnet

@superyarick
Copy link

superyarick commented Aug 7, 2020

Good catch on the Telnet. Double-check the "/usr/sbin/pam_timestamp_check" fix as it is still failing.


  ×  V-75789: Successful/unsuccessful uses of the pam_timestamp_check command must
  generate an audit record.
     ×  Control Source Code Error ./controls/V-75789.rb:3 
     undefined method `index' for nil:NilClass

@xtreme-nitin-ravindran
Copy link
Contributor Author

xtreme-nitin-ravindran commented Aug 7, 2020

@superyarick The error is unrelated to the change to the pam_timestamp_check path.

It is caused by line

audit_lines_exist = !auditd.lines.index { |line| line.include?(@audit_file) }.nil?

auditd.lines is nil when using dokken driver. There are other controls having the same error V-75775, V-75767, V-75695, etc.

The error does not show up when using vagrant driver.

The errors also occur on master branch

@aaronlippold
Copy link
Member

So if we add in platform.docker? or similar we should be able to adjust this test so it runs or skips correctly in both the container context and the vm context

@aaronlippold aaronlippold merged commit 4a56525 into mitre:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants