Split detailed comparisons in household inference #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on previous PRs, this PR splits up the inspection of candidate links into multiple steps to reduce the maximum memory requirements of that step. The size of each iteration is driven by the split_factor argument added previously
This PR also tweaks the preprocessing of the PII file a little bit, to ensure that the parse_addr function is only called once per row. Previously it would parse once per row at the start of the script, then once per row again each time a pair was evaluated. Based on timing this seems to reduce runtime by 66%.