Skip to content
This repository has been archived by the owner on Aug 31, 2019. It is now read-only.

If JSON.parse fails, the website does not inform the user #97

Open
lukemalinowski opened this issue Aug 2, 2019 · 0 comments
Open

If JSON.parse fails, the website does not inform the user #97

lukemalinowski opened this issue Aug 2, 2019 · 0 comments
Assignees
@lukemalinowski
Labels
bug Something isn't working Component Issues that relate to Vue Components
Projects
Components

Comments

@lukemalinowski
Copy link
Contributor

Currently if a non-JSON, or incorrect schema file is uploaded the site will give the user no notification of what happened. An error like what is thrown on results for profile errors, or a more prominent notification should be thrown.
@lukemalinowski lukemalinowski added bug Something isn't working Component Issues that relate to Vue Components labels Aug 2, 2019
@lukemalinowski lukemalinowski self-assigned this Aug 2, 2019
@lukemalinowski lukemalinowski added this to To do in Components via automation Aug 2, 2019
lukemalinowski added a commit that referenced this issue Aug 6, 2019
@lukemalinowski
ENH: Add support for callbacks on JSON.parse error
7f4d120 
Add callback option to dispatcher for load_file, only one so far,
that is for if JSON.parse() errors out due to syntax error.

A better way to do this is to write a Toast component, and send
TOAST_MESSAGES through vuex whenever an error happens, but this works
for testing now.

Related to #97

Signed-off-by: Luke Malinowski <lmalinowski@mitre.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lukemalinowski lukemalinowski

Labels
bug Something isn't working Component Issues that relate to Vue Components
Projects
Components
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukemalinowski