Health check #152
Merged
Health check #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is deployed here: heimdall-fb2fec87-1918573966.us-east-1.elb.amazonaws.com Health check is: heimdall-fb2fec87-1918573966.us-east-1.elb.amazonaws.com/health_check |
Signed-off-by: Armaan Mehta <amehta@mitre.org>
Added health_check to gem lock file for docker image build. Signed-off-by: Armaan Mehta <amehta@mitre.org>
amehta-mitre
force-pushed
the
health_check
branch
from
c21d68d
to
3037701
Compare
rbclark
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in the course of human events becomes necessary for one peoples to dissolve the timeout bandwidth that connected them with dysfunctional load balancers and to assume the among the powers of Docker the separate and equal station to which the laws of Computer Science and Computer Engineering entitle them, a decent respect to the opinions of high availability requires that they should declare causes which impel them to health checks. We hold these truths that all instances are created equal and that they are endowed by MITRE with resilient capabilities, that among these are high availability, scalability and cost effectiveness.
TLDR This PR adds the health_check gem and defaults to that gem's default settings. /health_check returns success 200 after Heimdall is running and the AWS ALB uses this path to validate Heimdall is healthy. The terraform deployment creates a load balancer that needs a health check endpoint that it can monitor to deregisters fargate tasks when an instance doesn't return healthy. @amehta-mitre