Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package.json Fix #5727

Merged
merged 12 commits into from
Apr 16, 2024
Merged

Package.json Fix #5727

merged 12 commits into from
Apr 16, 2024

Conversation

DMedina6
Copy link
Contributor

@DMedina6 DMedina6 commented Apr 15, 2024

This modifies the package.json file to use the .env file located in ./apps/backend/ rather than the root directory.

This also modifies the readme to be more explicit about which .env is being used and where it's located for both dockerized and locally hosted application builds.

Documentation was previously unclear and stated that the .env file in ./apps/backend/ is what is used for local builds even though it was actually pulling from the .env in the root directory?

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@em-c-rod em-c-rod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like Amndeep's suggestion and otherwise approve of these changes. Thanks!

README.md Outdated Show resolved Hide resolved
@georgedias georgedias added the ready-to-merge Used by mergify to identify if a PR is ready to merge into master. label Apr 16, 2024
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mergify mergify bot merged commit 3f02b12 into master Apr 16, 2024
19 checks passed
@mergify mergify bot deleted the package-fix branch April 16, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Used by mergify to identify if a PR is ready to merge into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants