control fixes for existing controls #5
Conversation
|
Please address the issue addressed in #6 |
|
Please address the issue addressed in #7 |
|
@rx294 As of 11/6/2019, 266 controls have been addressed and 9 controls are remaining since I'm unable to move forward with resolving the issues (#14 and #15). Here's the updated spreadsheet. |
* control fixes so inspec v4.18 can run execute * update inspec.yml
|
@rx294 the latest commits since my last comment resolve all remaining issues and should have addressed the entire control set in the profile. Please review.
|
| @@ -63,7 +63,7 @@ | |||
| end | |||
| end | |||
|
|
|||
| if !domain_role == '4' && !domain_role == '5' | |||
| if !(domain_role == '4') && !(domain_role == '5') | |||
There was a problem hiding this comment.
unless (domain_role == 4 || domain_role==5)
I have reviewed about 249 controls and these include the 22 files that have changed in this PR.
The list is attached here.
Fixes #6
Fixes #7
Fixes #8
Fixes #9
Fixes #11
Fixes #12
Fixes #13
Fixes #14
Fixes #15
Fixes #16
Fixes #17
Fixes #18
Fixes #19
Fixes #20
Fixes #21
Fixes #22
Aaron Lippold lippold@gmail.com