Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize 2016 baseline #61

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Parameterize 2016 baseline #61

wants to merge 13 commits into from

Conversation

ejaronne
Copy link
Collaborator

@ejaronne ejaronne commented Jun 13, 2023 •
edited by karikarshivani

Steps:

  • Follow the tracker to parameterize controls as needed
  • Share the V number if the code is long and needs parameterization of roughly over 3 values
  • Check the inspec.yml of 2019 and 2016 to find any missing inputs

@damif5
declared an input for passlock duration and used it
8e3a72a 
Signed-off-by: Dami Afolabi <dami.afolabi@icloud.com>
@damif5
parameterized V-77309
20dd32c 
Signed-off-by: Dami Afolabi <dami.afolabi@icloud.com>
@damif5
declared and used an input for V-73311
ab89d64 
Signed-off-by: Dami Afolabi <dami.afolabi@icloud.com>
@damif5
declared and used an input for V-73313
439e197 
Signed-off-by: Dami Afolabi <dami.afolabi@icloud.com>
@damif5
declared and used an input for V-73231
52edb5c 
Signed-off-by: Dami Afolabi <dami.afolabi@icloud.com>
@damif5
declared and used an input for V-73641
8bdaa6f 
Signed-off-by: Dami Afolabi <dami.afolabi@icloud.com>
@damif5
semantic change for V-73641 where it said monthly
5e40da9 
Signed-off-by: Dami Afolabi <dami.afolabi@icloud.com>
@damif5
semantic change for V-73641 where it said 60
7dad826 
Signed-off-by: Dami Afolabi <dami.afolabi@icloud.com>
@karikarshivani karikarshivani self-requested a review June 13, 2023 19:46
karikarshivani
karikarshivani reviewed Jun 13, 2023
View reviewed changes
inspec.yml
@@ -54,6 +54,31 @@ inputs:
type: Numeric
value: 3

- name: pass_lock_duration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add V numbers for all the inputs?

damif5 and others added 5 commits June 14, 2023 10:39
@damif5
parameterized the controls and updated some codes per comments in the PR
f38559a 
Signed-off-by: Dami Afolabi <dami.afolabi@icloud.com>
@karikarshivani
Merge branch 'master' of https://github.com/mitre/microsoft-windows-s…
86efad3 
…erver-2016-stig-baseline into parameterize

Pulling in changes from ab branch addressing issue 59
@damif5
updated V-73387 and removed the unused input
502bbfd 
Signed-off-by: Dami Afolabi <dami.afolabi@icloud.com>
@damif5
Merge branch 'parameterize' of https://github.com/mitre/microsoft-win…
b93ecc0 
…dows-server-2016-stig-baseline into parameterize
@damif5
added inputs
8a59640 
Signed-off-by: Dami Afolabi <dami.afolabi@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karikarshivani karikarshivani karikarshivani left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ejaronne @karikarshivani @damif5