Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Describe blocks for consistency #105

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

abailey1021
Copy link
Contributor

@abailey1021 abailey1021 commented Jun 5, 2023

Updated controls for describe block consistency. Please let me know if there are any issues. Thanks.

resolves #75

Signed-off-by: Aaron Bailey <abailey@erpinternational.com>
Copy link
Contributor

@karikarshivani karikarshivani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment pending about added accepted values (for consistency). Everything else looks great!

Signed-off-by: Aaron Bailey <abailey@erpinternational.com>
@abailey1021
Copy link
Contributor Author

Changes made and tested against V-93249.

Copy link
Contributor

@karikarshivani karikarshivani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@karikarshivani karikarshivani merged commit fc52876 into main Jun 26, 2023
@karikarshivani karikarshivani deleted the ab_inconsistentdesc75 branch June 26, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent describe.one blocks
2 participants