Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obsolete IDs in adversary #572

Closed
wants to merge 2 commits into from
Closed

Conversation

Guil33
Copy link

@Guil33 Guil33 commented Mar 14, 2024

Description

Fixes mitre/caldera#2917.

The obsolete objective ID has been removed entirely, thus the default will be used.

The obsolete abilities IDs have all been replaced with the current IDs. Using the comments next to the IDs in the adversary, the correct ability was obvious, e.g.

  • ff78708e0e18d31c0be7a2be295158ec # Windows File Extension Masquerading
    where the ability doesn't exist, turns into
  • 2f32a5c66db68b291469a3ab49be9261 # Windows File Extension Masquerading
    where 2f32a5c66db68b291469a3ab49be9261 is an ability named "File Extension Masquerading" that has only one Executor for Windows.

This is the same for each updated ability.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

With the commits, the Warnings related to this adversary are removed, and the abilities are now available in the adversary.
image
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Guil33
Copy link
Author

Guil33 commented Mar 28, 2024

Closing this PR since it actually doesn't solve the underlying issue and would only be a temporary fix, see linked issue: mitre/caldera#2917

@Guil33 Guil33 closed this Mar 28, 2024
@Guil33 Guil33 deleted the fix-old-abilities branch March 28, 2024 09:56
@elegantmoose
Copy link
Contributor

@Guil33 Confirmed these are correct abilities, with new ID.

Welcome to reopen.

@Guil33
Copy link
Author

Guil33 commented Apr 29, 2024

Alright.
Re-checked the IDs on 2024/04/29 on a brand new instance, no change needed.
I will reopen this on another account (company policy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reliance on non-static IDs for third-party abilities triggers Warnings at every startup
3 participants