Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugged: added the missing currentUserId prop to RuleEditorHeader co… #486

Merged
merged 8 commits into from
Oct 15, 2022
Merged

Debugged: added the missing currentUserId prop to RuleEditorHeader co… #486

merged 8 commits into from
Oct 15, 2022

Conversation

vanessuniq
Copy link
Contributor

…mponent

A user with author role should now be able to revoke the review request they initiated.
Signed-off-by: Vanessa Fotso vfotso@mitre.org

@vanessuniq
Debugged: added the missing currentUserId prop to RuleEditorHeader co…
f9b6383 
…mponent

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq linked an issue Oct 7, 2022 that may be closed by this pull request
A user with the author role cannot revoke a review request they initiated. #479
Closed
@vanessuniq vanessuniq added bug Something isn't working javascript Pull requests that update Javascript code labels Oct 7, 2022
@vanessuniq
Copy link
Contributor Author

Preview - https://vulcan-479-a-user-with--rw418q.herokuapp.com/users/sign_in

@vanessuniq vanessuniq requested a review from rlakey October 7, 2022 22:01
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-486 October 10, 2022 20:08 Inactive
@vanessuniq vanessuniq marked this pull request as draft October 10, 2022 20:22
@vanessuniq vanessuniq force-pushed the 479-a-user-with-the-author-role-cannot-revoke-a-review-request-they-initiated branch from c93c36f to 9713e20 Compare October 11, 2022 02:11
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-486 October 11, 2022 02:11 Inactive
@vanessuniq
Upgraded eslint dependencies and eslint rules to spot/warn undefined …
9fba426 
…properties

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-486 October 11, 2022 02:15 Inactive
@vanessuniq
Turning off the vue/no-undef-properties because of too many false pos…
6730296 
…itives

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-486 October 11, 2022 03:45 Inactive
@vanessuniq vanessuniq marked this pull request as ready for review October 11, 2022 16:52
Amndeep7
Amndeep7 requested changes Oct 11, 2022
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc.js Show resolved Hide resolved
app/javascript/components/rules/RuleNavigator.vue Show resolved Hide resolved
jsconfig.json Show resolved Hide resolved
@vanessuniq
Cleanup unecessary comments
59a13d6 
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq
Upgrade heroku postgresql plan to basic
58a8d39 
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-486 October 12, 2022 22:32 Inactive
vanessuniq
vanessuniq commented Oct 15, 2022
View reviewed changes
Copy link
Contributor Author

@vanessuniq vanessuniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the changes

jsconfig.json Show resolved Hide resolved
app/javascript/components/rules/RuleNavigator.vue Show resolved Hide resolved
@Amndeep7 Amndeep7 merged commit 73ea8c0 into master Oct 15, 2022
@Amndeep7 Amndeep7 deleted the 479-a-user-with-the-author-role-cannot-revoke-a-review-request-they-initiated branch October 15, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amndeep7 Amndeep7 Amndeep7 approved these changes

@rlakey rlakey Awaiting requested review from rlakey

Assignees
No one assigned
Labels
bug Something isn't working javascript Pull requests that update Javascript code
Projects
Vulcan - Project Plan
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A user with the author role cannot revoke a review request they initiated.
2 participants
@vanessuniq @Amndeep7