Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature DISA Export Excel complete with tests #529

Merged
merged 6 commits into from
Feb 1, 2023
Merged

Feature DISA Export Excel complete with tests #529

merged 6 commits into from
Feb 1, 2023

Conversation

smarlaku820
Copy link
Contributor

  • Modified the Project.vue to add a new option for exporting the excel by component in DISA format
  • Updated the project controller to pass on that actions to export helper with a is_disa_export flag
  • Modified the export_excel function to adjust for excel export in the DISA format
  • Modifed the Rspec tests
  • Ran rubocop & yarn lint before pushing the commits.

@smarlaku820 smarlaku820 linked an issue Feb 1, 2023 that may be closed by this pull request
Add "DISA Excel Export" option #527
Closed
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-529 February 1, 2023 16:26 Inactive
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-529 February 1, 2023 16:39 Inactive
@smarlaku820 smarlaku820 added enhancement Pull requests that add a new feature V3.0 vmw labels Feb 1, 2023
@vanessuniq vanessuniq enabled auto-merge (squash) February 1, 2023 17:41
vanessuniq
vanessuniq requested changes Feb 1, 2023
View reviewed changes
app/helpers/export_helper.rb Outdated Show resolved Hide resolved
app/helpers/export_helper.rb Outdated Show resolved Hide resolved
@rlakey @vanessuniq
updating disa status texts to hash
ba60cb7 
Co-authored-by: Vanessa Fotso <46642178+vanessuniq@users.noreply.github.com>
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-529 February 1, 2023 21:58 Inactive
@rlakey @vanessuniq
Update app/helpers/export_helper.rb
9023336 
Co-authored-by: Vanessa Fotso <46642178+vanessuniq@users.noreply.github.com>
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-529 February 1, 2023 21:58 Inactive
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-529 February 1, 2023 22:28 Inactive
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-529 February 1, 2023 23:05 Inactive
@vanessuniq vanessuniq merged commit 42c3277 into master Feb 1, 2023
@vanessuniq vanessuniq deleted the 527-add-disa-excel-export-option branch February 1, 2023 23:18
@smarlaku820 smarlaku820 self-assigned this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanessuniq vanessuniq vanessuniq approved these changes

Assignees

@smarlaku820 smarlaku820

Labels
enhancement Pull requests that add a new feature V3.0 vmw
Projects
Vulcan - Project Plan
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "DISA Excel Export" option
3 participants
@smarlaku820 @vanessuniq @rlakey