Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created an ENV variable for controlling USER registrations on Vulcan app (Enabled by Default) #535

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

smarlaku820
Copy link
Contributor

  • Created an ENV variable (VULCAN_ENABLE_USER_REGISTRATION) in vulcan.default.yml file
  • Updated the config/initializers accordingly
  • Created a Boolean helper function
  • Updated the view to display User "Register" form based on the outcome of the Boolean helper function

@smarlaku820 smarlaku820 linked an issue Feb 8, 2023 that may be closed by this pull request
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-535 February 8, 2023 18:00 Inactive
@smarlaku820 smarlaku820 added ux Addresses change on the user interface V3.0 vmw labels Feb 8, 2023
@rlakey rlakey assigned smarlaku820 and unassigned vanessuniq Feb 8, 2023
@rlakey
Copy link
Contributor

rlakey commented Feb 8, 2023

Vanessa the goal was to allow us to disable local user registration while still keeping local login enabled for emergency access but not allow anyone to randomly register new local accounts.

Also to keep the current default behavior of local login and registration enabled.

@vanessuniq
Copy link
Contributor

vanessuniq commented Feb 8, 2023

Got it, will the registration be by invitation only if registration disabled?
if yes, is registration by invitation enabled?

@vanessuniq vanessuniq enabled auto-merge (squash) February 8, 2023 19:11
@rlakey
Copy link
Contributor

rlakey commented Feb 8, 2023

No this is more for if we are using another authentication method such as LDAP or OIDC where local logins are not needed.

Copy link
Contributor

@vanessuniq vanessuniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add the new env VULCAN_ENABLE_USER_REGISTRATION to the doc (/docs/config.md)

@vanessuniq vanessuniq temporarily deployed to vulcan-pr-535 February 8, 2023 20:34 Inactive
@vanessuniq vanessuniq merged commit faa8f0f into master Feb 8, 2023
@vanessuniq vanessuniq deleted the 338-add-option-to-disable-registration branch February 8, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux Addresses change on the user interface V3.0 vmw
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable registration
3 participants