Group histories with the same name, created_at, and comment; add tooltip for rule status #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanessuniq
added
javascript
|
How the tooltip looks like now
|
|
Tooltip looks great! |
rlakey
approved these changes
Apr 14, 2023
vanessuniq
force-pushed
the
enhencement_patch
branch
from
ddf3193
to
a36f770
Compare
…omment Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
vanessuniq
force-pushed
the
enhencement_patch
branch
from
a36f770
to
ac1f457
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the need to group histories with the same name, created_at, and comment, and adds a tooltip explaining the options for rule status. The changes introduced in this PR include:
HistoryGroupingMixin.vue.HistoryGroupingMixin.vuemixin in both the parent (RuleHistories.vue) and child (History.vue) components.With these changes, histories with the same name, created_at, and comment are now grouped together, and the history count badge in the parent component displays the correct grouped count. Additionally, users can now view an informative tooltip that explains the options for rule status.