fix project update logic for detecting name changes correctly #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified the project update logic in the update action; Introduced the project_name_changed? method to check if the project name has changed.;
smarlaku820
added
bug
freddyfeelgood
approved these changes
May 16, 2023
vanessuniq
approved these changes
May 16, 2023
vanessuniq
deleted the
579-bug-vulcan-project-metadata-update-triggers-project_rename-slack-notification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted in the below screenshot, when project metadata is updated it is triggering a
rename_projectslack notification.Project Metadata Update:
Slack Notification Triggered:
Fix -
project_name_changed?method to check if the project name has changed.After this
project_renameslack notification is not triggered if metadata is updated. And the flash messages are also updated accordingly.