Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain the selectable list to allow only Apllicable - Configurable controls to be satisfied by other #586

Conversation

vanessuniq
Copy link
Contributor

No description provided.

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq added bug Something isn't working javascript Pull requests that update Javascript code feature request labels Jun 5, 2023
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-586 June 5, 2023 15:14 Inactive
@vanessuniq vanessuniq enabled auto-merge (squash) June 5, 2023 15:15
@freddyfeelgood
Copy link
Contributor

Hey Vanessa, this logic seems almost "backwards" to me... What should happen is that only "Applicable - Configurable" controls can be "parents", and then creating a "satisfies" link to another requirement automatically makes that "child" requirement assume the "Applicable - Configurable" status.

Before, when the "Mark as Duplicate" button was there, the action was taken on the "Child" requirement, so it would make sense to filter the list to only "AC" items, because that would become the "parent".

Now, because the "Add+" action is taken from the "parent" item, I think the list should contain basically everything. However, the "Add+" button should probably only be visible on items with a status of "AC" that are not "children" to other items.

@rlakey, thoughts?

@rlakey
Copy link
Contributor

rlakey commented Jun 5, 2023

Hey Vanessa, this logic seems almost "backwards" to me... What should happen is that only "Applicable - Configurable" controls can be "parents", and then creating a "satisfies" link to another requirement automatically makes that "child" requirement assume the "Applicable - Configurable" status.

Before, when the "Mark as Duplicate" button was there, the action was taken on the "Child" requirement, so it would make sense to filter the list to only "AC" items, because that would become the "parent".

Now, because the "Add+" action is taken from the "parent" item, I think the list should contain basically everything. However, the "Add+" button should probably only be visible on items with a status of "AC" that are not "children" to other items.

@rlakey, thoughts?

You're right and I wasn't as clear as I could have been in the issue I opened on this and probably mixed in the old and new behavior from the UI updates. It came up because I was fixing some items that we had marked as satisfied by but the parent was later changed to N/A or something else not configurable. Maybe the thing here, like you said, is to only show the add button on configurable items.

…rols

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-586 June 5, 2023 20:35 Inactive
@vanessuniq
Copy link
Contributor Author

Now the Add button only appears on Applicable - Configurable controls.

Copy link
Contributor

@freddyfeelgood freddyfeelgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a few tests and everything looks correct. Thanks!

@vanessuniq vanessuniq merged commit aa0358a into master Jun 5, 2023
1 check passed
@vanessuniq vanessuniq deleted the 585-add-constraint-to-satisfies-workflow-for-configurable-only-requirements branch June 5, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request javascript Pull requests that update Javascript code
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Add constraint to satisfies workflow for configurable only requirements.
3 participants