Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain requirement for locking Applicable -Does Not Meet and Applicable - Inherently Meets controls #587

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Constrain requirement for locking Applicable -Does Not Meet and Applicable - Inherently Meets controls #587

merged 1 commit into from
Jun 7, 2023

Conversation

vanessuniq
Copy link
Contributor

  • Prevent locking Applicable - Does Not Meet controls with no mitigations
  • Prevent locking Applicable - Inherently Meets Controls with no artifact description

Fix #577
Fix #578

@vanessuniq
Constrain requirement for locking Applicable -Does Not Meet and Appli…
61cf5f7 
…cable - Inherently Meets controls

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq added bug Something isn't working javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code feature request labels Jun 6, 2023
@vanessuniq vanessuniq linked an issue Jun 6, 2023 that may be closed by this pull request
The Mitigation field must be populated if the requirement Status is 'Applicable - Does Not Meet' #578
Closed
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-587 June 6, 2023 21:04 Inactive
@vanessuniq vanessuniq enabled auto-merge (squash) June 6, 2023 21:04
freddyfeelgood
freddyfeelgood approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@freddyfeelgood freddyfeelgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested from both the "main" screen, with the "lock all controls" button, and from individual requirements, clicking the "Review" button which shows the options. I like that "lock" is grayed out as an option if the required fields are not filled in.

@vanessuniq vanessuniq merged commit f197e3e into master Jun 7, 2023
5 checks passed
@vanessuniq vanessuniq deleted the 578-the-mitigation-field-must-be-populated-if-the-requirement-status-is-applicable-does-not-meet branch June 7, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddyfeelgood freddyfeelgood freddyfeelgood approved these changes

@aaronlippold aaronlippold Awaiting requested review from aaronlippold

@rlakey rlakey Awaiting requested review from rlakey

Assignees
No one assigned
Labels
bug Something isn't working feature request javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code
Projects
Vulcan - Project Plan
Status: Merged
Milestone
No milestone
2 participants
@vanessuniq @freddyfeelgood