Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Capture STIG Name on Upload #603

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Fix: Capture STIG Name on Upload #603

merged 1 commit into from
Aug 24, 2023

Conversation

vanessuniq
Copy link
Contributor

  • Enforced not null constraint on the name column of the stigs table.
  • Updated Stig model to validate the presence of the name field.
  • Updated .from_mapping method of Stig and SecurityRequirementsGuide model to capture the name when initializing the instance
  • Updated Stig specs

This will ensure that every STIG has an associated name when created, and prevent display null data on the UI.

…entsGuide to capture name on initialize and updated spec

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq added the bug Something isn't working label Aug 24, 2023
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-603 August 24, 2023 16:52 Inactive
@vanessuniq vanessuniq enabled auto-merge (squash) August 24, 2023 16:55
Copy link
Contributor

@freddyfeelgood freddyfeelgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the "null" header on the related items modal:

image

@vanessuniq vanessuniq merged commit 140aa6f into master Aug 24, 2023
2 checks passed
@vanessuniq vanessuniq deleted the fix_stig_upload branch August 24, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

None yet

2 participants