Fix Firefox 32 #69
Merged
Fix Firefox 32 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event object now appears to be immutable in FF32, so mutations to the object were failing.
|
It would be worthwhile testing with Electrolysis enabled in a current Nightly; it'll bump into issues similar to this one. https://wiki.mozilla.org/Electrolysis |
|
@ahilss I love you |
|
Yeah, thanks a ton for the fix! On Oct 13, 2014, at 9:53 AM, Marco De Nadai notifications@github.com wrote:
|
shanewho
pushed a commit
to shanewho/mitro
that referenced
this pull request
Nov 3, 2014
Fix Firefox 32
|
Any idea when this fix might make it into a stable release? Especially considering we're up to Firefox 35 now o_0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event objects passed into page_worker message handlers now appear to be immutable in FF32. We were mutating the event object by adding a setResponse function and replacing _callback_x strings in the message args with onSuccess and onError handlers. This is why we were seeing exceptions about onError being undefined. Making a deep copy of the message data fixes the issue.
It looks like events passed in contexts other than page_worker are still mutable, but we should still fix them to protect against changes like this in the future. Mutating input parameters is a bad idea, especially when those parameters come from third-party code.