fixed Firefox popup size issue #89
Conversation
|
To explain better this issue: the popup was displaying the web version, with huge problems of usability. (Why is the popup spaced 7px from the border?) |
|
Is that fixing Windows 7 FF 33 too? I just saw that this is still not working. I was just concerned about OSX which got a fix some weeks ago. |
|
I think yes, but I can't try it :(( |
|
I think I still have a buildable copy (where I could apply your patch) on my development system and a win7 vm. I may try it later tonight. |
|
nice |
| @@ -83,7 +83,7 @@ var updateLoginState = function () { | |||
| } | |||
| helper.tabs.create({url: helper.getURL('html/change-password.html' + hash)}); | |||
| } else { | |||
| if (($(window).width() > POPUP_WIDTH) && debugMode === false) { // Check to see if this in browser window, not popup | |||
| if (($(window).width() > POPUP_WIDTH+7) && debugMode === false) { // Check to see if this in browser window, not popup | |||
There was a problem hiding this comment.
please declare this as a constant at the top. Magic numbers in the middle of code like this is scary, especially when they're repeated. Also spaces around the +.
There was a problem hiding this comment.
Actually, its also possible this means the POPUP_WIDTH should be adjusted directly? Does it get used elsewhere?
We had another bug report (issue #96) that someone thinks this should fix. If we can clean up this pull request I'm happy to merge it and attempt a release.
|
Fixes #96 |
|
Will someone merge this? Please! Is anybody using Firefox at all, anymore? Please, faster |
|
I couldn't get the extension to build on my machine, so I edited the code right in my firefox profile folder since the PR was only 4 characters, and it works for me. |
|
ping. Would it make sense to fork this and take over maintenance? |
|
then we would not have any official release :) |
Fixes #40