Code cleaning

[denadai2]

I removed the Firefox-addon-sdk, hogan.js and closurelibrary from the third_part directory. Now they are not tracked in github (they are not part of the project, they are requirements now!).

I made a "build.sh" script that installs everything automatically

[vijayp]

Great idea! For some reason there appears to be a merge conflict. I'd like to check it out and verify everything builds correctly before merging this. If you could fix any conflicts, I can try tomorrow.

[bgw]

I think it would make more sense to use git submodules for this. As an added advantage, the folders would be pinned to a specific commit, which would prevent issues when upstream updates their repositories.

[denadai2]

we can clone a specific commit. A submodule includes the code, which is not
necessary imho...

anyway I'll check the tests ASAP

2014-12-16 23:48 GMT+01:00 Benjamin Woodruff notifications@github.com:

In browser-ext/login/build.sh
#91 (diff):

+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see http://www.gnu.org/licenses/.
+#
+# You can contact the authors at inbound@mitro.co.
+# *****************************************************************************
+#
+
+set -e
+
+ABSOLUTE_BUILD=pwd/../third_party
+
+git clone "https://github.com/mozilla/addon-sdk.git" "$ABSOLUTE_BUILD/firefox-addon-sdk"

I think it would make more sense to use git submodules for this. As an
added advantage, the folders would be pinned to a specific commit, which
would prevent issues when upstream updates their repositories.

—
Reply to this email directly or view it on GitHub
https://github.com/mitro-co/mitro/pull/91/files#r21939181.

Marco De Nadai
me@marcodena.it me@marcodena.it
http://www.marcodena.it/
http://www.marcodena.it/?utm_source=email&utm_medium=email&utm_campaign=Email%2Bpersonali

[bgw]

It doesn't include the code. Rather, it's a reference to a repository url and commit id using a few metadata files (.gitmodules, .git/config). Perhaps you're confusing it with a git-subtree?