Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write python dictionary to XML #131

Merged
merged 2 commits into from May 19, 2020
Merged

Write python dictionary to XML #131

merged 2 commits into from May 19, 2020

Conversation

bathal1
Copy link
Contributor

@bathal1 bathal1 commented May 11, 2020 •
edited

Implementation of the XML writing routine, which can be used with python dictionaries created either by users or by the blender exporter addon

@bathal1 bathal1 changed the title Write python dictionary to XML WIP: Write python dictionary to XML May 11, 2020
@bathal1 bathal1 marked this pull request as draft May 11, 2020 06:44
Speierers
Speierers reviewed May 11, 2020
View reviewed changes
Copy link
Member

@Speierers Speierers left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress @bathal1 !

Here are a couple comments

src/libcore/tests/test_xml.py Outdated Show resolved Hide resolved
src/libcore/tests/test_xml.py Outdated Show resolved Hide resolved
src/libcore/tests/test_xml.py Outdated Show resolved Hide resolved
src/libcore/tests/test_xml.py Outdated Show resolved Hide resolved
src/libcore/tests/test_xml.py Outdated Show resolved Hide resolved
src/python/python/dict_to_xml.py Outdated Show resolved Hide resolved
src/python/python/dict_to_xml.py Outdated Show resolved Hide resolved
src/python/python/dict_to_xml.py Outdated Show resolved Hide resolved
src/python/python/dict_to_xml.py Outdated Show resolved Hide resolved
src/python/python/dict_to_xml.py Outdated Show resolved Hide resolved
@bathal1 bathal1 force-pushed the write_xml branch 2 times, most recently from f1f8760 to 74c0f2a Compare May 15, 2020 07:39
@bathal1 bathal1 marked this pull request as ready for review May 15, 2020 07:40
Speierers
Speierers reviewed May 15, 2020
View reviewed changes
src/libcore/xml.cpp Outdated Show resolved Hide resolved
src/librender/mesh.cpp Outdated Show resolved Hide resolved
src/librender/mesh.cpp Outdated Show resolved Hide resolved
Speierers
Speierers reviewed May 15, 2020
View reviewed changes
src/python/python/xml.py Outdated Show resolved Hide resolved
src/python/python/xml.py Outdated Show resolved Hide resolved
src/python/python/xml.py Show resolved Hide resolved
src/python/python/xml.py Show resolved Hide resolved
src/python/python/xml.py Outdated Show resolved Hide resolved
Speierers
Speierers reviewed May 15, 2020
View reviewed changes
src/python/python/xml.py Outdated Show resolved Hide resolved
Speierers
Speierers reviewed May 15, 2020
View reviewed changes
src/python/python/xml.py Outdated Show resolved Hide resolved
Speierers
Speierers reviewed May 15, 2020
View reviewed changes
src/python/python/xml.py Outdated Show resolved Hide resolved
Speierers
Speierers reviewed May 15, 2020
View reviewed changes
src/python/python/xml.py Outdated Show resolved Hide resolved
Speierers
Speierers reviewed May 15, 2020
View reviewed changes
src/python/python/xml.py Outdated Show resolved Hide resolved
Speierers
Speierers reviewed May 15, 2020
View reviewed changes
src/python/python/xml.py Outdated Show resolved Hide resolved
@bathal1 bathal1 force-pushed the write_xml branch 2 times, most recently from 8743088 to a5167f1 Compare May 19, 2020 09:19
@Speierers Speierers changed the title WIP: Write python dictionary to XML Write python dictionary to XML May 19, 2020
@bathal1 bathal1 force-pushed the write_xml branch 2 times, most recently from 94fd3f9 to 1690963 Compare May 19, 2020 11:56
@Speierers Speierers merged commit 2655911 into mitsuba-renderer:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Speierers Speierers Speierers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bathal1 @Speierers