Merge updates from previous PRs; as well as py3 compat fixes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…press Conflicts: jinja2htmlcompress.py
…Compress Added inverted stripper to HTMLCompress
…ng off global stripping via 'htmlcompress.default_active' policy.
now issues deprecation warning.
eli-collins
force-pushed
the
master
branch
2 times, most recently
from
b92dc99
to
bc5c049
Compare
updates constants to match HTML5 spec, reworked leave_tag() for clarity.
simplifies a bunch of the code, and consolidates parser state in one place.
now aware of "block" vs "inline" elements, and preserves 1 space around inline elements, to prevent layout errors. additionally, tries to use more information about parsing state in order to only strip spaces where it won't potentially cause a syntax error once rendered. this also moves the brunt of normalize() into an internal generator function, _feed()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a big bundle of changes:
{% strip [true|false] %} .. {% endstrip %}syntax, so certain blocks can be explicitly enabled/disabled.I'm going to be using this a bit in production, so if/until this is merged, will try to keep my branch up to date.Update: After exploring how to enhance this extension further, I ran into a number of architectural obstacles, and decided that using jinja's lstrip_blocks & trim_blocks flags will probably be overall easier for me to deploy, despite those flags' "all or nothing" behavior.