Add do tag to allow calling functions/macros and not having output #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The do tag does the same thing as a using regular template tags (`{{ ...
}}`); except it doesn't output anything.
This is useful if you have a function or macro that has verbose output
or side effects, but you don鈥檛 want to display output.
joshuataylor
commented
Jan 6, 2023
| @@ -953,7 +954,6 @@ impl<'a> Parser<'a> { | |||
| Ok(ast::FromImport { expr, names }) | |||
| } | |||
|
|
|||
| #[cfg(feature = "macros")] | |||
There was a problem hiding this comment.
As functions can be called via do, this needed to be removed. Thoughts?
joshuataylor
commented
Jan 6, 2023
| expect_token!(self, Token::BlockEnd(..), "end of block"); | ||
|
|
||
| // End of block may not exist, for example with do block. | ||
| if let Some((Token::BlockEnd(..), _)) = ok!(self.stream.current()) { |
There was a problem hiding this comment.
I'm not sure if this is the best way to check, or would lead to user confusion.
If they are using enddo, it will error anyway.
|
Ugh not sure what happened here. I did not intend on closing this. |
|
Ah I see. The merge base was my now deleted call block branch so this auto closed this PR as well. Can your rebase this off main? I'm in favor of adding this. |
|
Yep, seems rebasing should be fine, just doing that now. As you said, I had based this off the other branch, where deleting it closes this. Hopefully, I can rebase and it'll work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off this conversation: #83
Happy to discuss if this should be merged. Moreover, happy for this to be tweaked/reworked to make it in the best possible state. 馃殌
I also initially named this DoBlock, but IMHO it's confusing to name that as someone might think they could use it the same way they would the
calltag.What is a do tag?
The do tag does the same thing as a using regular template tags (
{{ ... }}); except it doesn't output anything.This is useful if you have a function or macro that has verbose output or side effects, but you want to avoid displaying output.
Reasoning
The reasoning for adding this is that this is super handy when working with projects that use jinja2 extensively, like dbt, where it's quite useful.
Example (from dbt-utils readme).
(I know you know most/all of this, but the explanation is for everyone else, and when I forget :D )