Make strict mode less strict #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibotty
reviewed
Apr 24, 2024
| @@ -56,6 +56,8 @@ For upgrade instructions read the [UPDATING](UPDATING.md) guide. | |||
| was raised to 100000. #493 | |||
| - `Value::from` is now implemented for `Error` as public API to create invalid values. | |||
| Previously this behavior was hidden internally in the serde support. #495 | |||
| - `UndefinedBehavior::Strict` now acts more delayed. This means that now `value.key is defined` | |||
| will no longer error when `value.key` is `undefined`. #500 | |||
There was a problem hiding this comment.
Isn't that a little wrong.
- `value.key` is `undefined`
+ `value` does not have a member `key`.or similarly.
There was a problem hiding this comment.
I fixed the sentence in the changelog:
UndefinedBehavior::Strictnow acts more delayed. This means that nowvalue.key is definedwill no longer fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498