Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve downcast_object_ref docs #512

Merged
merged 3 commits into from
May 8, 2024

Conversation

jplatte
Copy link
Sponsor Contributor

@jplatte jplatte commented May 8, 2024

No description provided.

@jplatte
Copy link
Sponsor Contributor Author

jplatte commented May 8, 2024

Looks like there's a new clippy lint out there! Many errors like this:

error: bound is defined in more than one place
   --> minijinja/src/value/serialize.rs:126:23
    |
126 |     fn serialize_some<T: ?Sized>(self, value: &T) -> Result<Value, InvalidValue>
    |                       ^
127 |     where
128 |         T: Serialize,
    |         ^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
    = note: `-D clippy::multiple-bound-locations` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::multiple_bound_locations)]`

Happy to provide another PR, do you want to silence the lint, move the ?Sized bounds to where clauses, or move the other bounds outside of where?

@mitsuhiko
Copy link
Owner

Fixed the warnings on main.

@mitsuhiko mitsuhiko merged commit 92332ad into mitsuhiko:main May 8, 2024
18 checks passed
@jplatte jplatte deleted the jplatte/downcast-docs branch May 8, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants