Remove the need for RefCell by requiring &mut ConnectionLike
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a rebased version of this in the |
Marwes
force-pushed
the
mut_connection
branch
2 times, most recently
from
0a8e6ac
to
116e465
Compare
BREAKING CHANGE
|
@badboy I rebased this using your |
|
I'll spend some time on this tomorrow and see if we go ahead with it. |
barshaul
pushed a commit
to barshaul/redis-rs
that referenced
this pull request
Jun 9, 2024
barshaul
pushed a commit
to barshaul/redis-rs
that referenced
this pull request
Jul 11, 2024
* Add persist() command to java (redis-rs#148) Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't anything in redis-rs that requires the
RefCellso users can always replicate the earlier behavior by themselves wrapping the connection in aRefCell.This might also protect against programmer errors when using
iterto query as one should not issue anotherquerywhile still using the iterator.BREAKING CHANGE
Changes the signature of several functions that took a
&ConnectionLiketo take&mut ConnectionLike