Fix some low level stream commands for redis cluster #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- xgroup and xinfo they have key position on 3rd place - xread and xreadgroup have key right after 'STREAMS' keyword
badboy
approved these changes
Feb 20, 2020
src/cluster.rs
Outdated
| b"XREAD" | b"XREADGROUP" => { | ||
| let streams_position = args | ||
| .iter() | ||
| .position(|a| *a == Value::Data(b"STREAMS".to_vec()))?; |
There was a problem hiding this comment.
Mini-optimisation: we can pull out the Value::Data(b"STREAMS".to_vec()) before the whole iteration, therefore saving us the frequent re-creation (and thus re-allocation)
There was a problem hiding this comment.
I missed that somehow, thanks.
It should be ok now?
Marwes
reviewed
Feb 20, 2020
badboy
approved these changes
Feb 20, 2020
badboy
reviewed
Feb 20, 2020
barshaul
pushed a commit
to barshaul/redis-rs
that referenced
this pull request
Jul 11, 2024
…ction Add transaction support to Node.
barshaul
pushed a commit
to barshaul/redis-rs
that referenced
this pull request
Jul 11, 2024
* Python: add SMOVE command (redis-rs#283) * Align docs and cross-slot test with recent changes * Fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix key position for stream commands:
xgroupandxinfohave key position on 3rd placexreadandxreadgrouphave key right after STREAMS keywordSmall note:
xreadandxreadgroupcommand can take multiple streams (multiple keys) and my proposed solution is calculating hash only based on first key.I think this assumption is correct because 2 things could happen:
(error) CROSSSLOT Keys in request don't hash to the same slot