Print line after server is started #1179 (from Flask)

[indriesergiu]

Moved the " * Running on host:port" message after the socket was opened for more message accuracy.
pallets/flask#1179

[untitaker]

I think we could move it into serve_forever for even more (theoretical) accuracy?

I like this patch, but FTR: I don't want to guarantee this behavior to the enduser -- they should still handle the case where the server has already printed that line but isn't ready to serve requests yet.

[indriesergiu]

Done. Moved the message output right before the HTTPServer.serve_forever(self) call.
Also, I agree, this kind of messages should no be relied upon for development. Polling remains the ultimate guarantee :)

Thanks

On Mon, May 11, 2015 at 2:28 PM Markus Unterwaditzer <
notifications@github.com> wrote:

I think we could move it into serve_forever for even more (theoretical)
accuracy?

I like this patch, but FTR: I don't want to guarantee this behavior to the
enduser -- they should still handle the case where the server has already
printed that line but isn't ready to serve requests yet.

—
Reply to this email directly or view it on GitHub
#732 (comment).

[untitaker]

Could you use rebase -i to squash your commits into one?

[indriesergiu]

Sorry about that. This is my first time using this fork & pull model. Does it still need cleanup?

[untitaker]

Please reopen, it was fine!

[untitaker]

You can use git rebase -i on your git branch to edit your commit history into one single commit. Currently you have three (see Commits-tab).

In your case, rebasing is an alternative to merging origin/master into your branch. You execute git rebase origin/master, which applies your commits on top of origin/master (re-creating them, rewriting history) instead of creating a merge commit. This is a good article about rebasing, I'm sure there are better ones too.

So what you should do is:

git rebase -i master

The -i switch will allow you to do all sorts of things with your commits. It will open your commit history in your editor, and you can replace pick/p with f to meld a commit into the previous one. Do so for all commits except the first one.

[untitaker]

Oh and because you wrote your history, you need to do push -f instead of push. All of this is common practice after somebody is done reviewing a PR, and it's time to clean up the history.

[indriesergiu]

That was the part I was missing I didn't use force so I saw the previous commits as well. Anyway, I hard reset to the last commit before me, push --force, reapplied patch and push. Hope it's fine now :)

[untitaker]

Thanks, that's fine. I'll wait for Travis to pass until I merge.

[indriesergiu]

I think the build passed :)

[untitaker]

Great, thanks!