Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(encoding): Fix malfunctioning encoding option #7

Merged
merged 2 commits into from
Apr 27, 2024
Merged

fix(encoding): Fix malfunctioning encoding option #7

merged 2 commits into from
Apr 27, 2024

Commits on Apr 27, 2024

  1. fix(encoding): Resolve encoding usage in the ls function 

    Previously, the encoding option are fully malfunctioned and can't be passed with other encodings except 'utf8', 'binary', and 'ascii' (in some cases). If we specify with 'hex' encoding, the function will throws an error (which is due to internal error) complaining an invalid path on the specific entry. Now it has been resolved and work as expected, thankfully to `encodeTo` internal function to encode the entries and vice versa, this also includes improving the resolution logic of `encoding` option to more strict and robust.
    @mitsuki31
    mitsuki31 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    b62712d View commit details
    Browse the repository at this point in the history

  2. test: Add new test cases to test encoding option

    @mitsuki31
    mitsuki31 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    46b776c View commit details
    Browse the repository at this point in the history