fix(build): Resolve bad invocation shell #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, during the building procedure, there was a problem with the invocation shell in the child process that used `child_process.spawn`. In Windows, this resulted in the process issuing an ENOENT error since the command was not recognized. However, with this modification, we resolved the issue and it now functions correctly in Windows by activating the `shell` option within the options argument (3rd argument) of the `spawn` function. Note: Tested in PowerShell and MSYS2 MinTTY. This change are exclusively to Windows users and developers.
mitsuki31
added
patch
mitsuki31
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before, during the building procedure, there was a problem with the invocation shell in the child process that used
child_process.spawn. In Windows, this resulted in the process issuing an ENOENT error since the command was not recognized. However, with this modification, we resolved the issue and it now functions correctly in Windows by activating theshelloption within the options argument (3rd argument) of thespawnfunction.Note
Tested in PowerShell and MSYS2 MinTTY. This change are exclusively to Windows users and developers.