Make Signaller HTTP-client more configurable #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces additional options for tweaking Signaller HTTP-client: * adjusting MaxConnsPerHost, MaxIdleConns, MaxIdleConnsPerHost on http.Transport fields if they are different from the default value of an according command-line argument, but with the possibility to set them to 0, because 0 is a valid value for them; * setting a timeout on Signaller HTTP-requests towards upstream; Also this commit adds draining of a response body from Signaler's upstream for improving connection reuse.
|
Hi, I still have some concerns about my implementation and would appreciate any feedback. Thank you in advance! |
|
There has not been any activity to this pull request in the last 14 days. It will automatically be closed after 7 more days. Remove the |
martin-helmich
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces additional options for tweaking Signaller HTTP-client:
http.Transport fields if they are different from the default value of
a corresponding command-line argument, but with the possibility to set
them to 0, because 0 is a valid value for them;
Also, this commit adds draining of a response body from Signaler's
upstream for improving connection reuse.