add explicit appProtocol spec to http service #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent issues with Istio automatic protocol selection
pczerkas
added a commit
to pczerkas/kube-apps-httpcache
that referenced
this pull request
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently patching manually the helm chart at each release to have the service to work with Istio so I propose this change
the app protocol should be explicit, to prevent issues with Istio automatic protocol selection
cf https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/
with current naming Istio will infer http/1 or http2
this should not impact other usages, and explicit appProtocol specification is also a good practice
thanks for your feedback