Add option to use a user provided secret for the admin credentials #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackjid
force-pushed
the
add_custom_secret
branch
from
f68e4e9
to
4030e78
Compare
martin-helmich
approved these changes
May 25, 2021
Yeah, it shouldn't. I'm still not entirely sure what's the actual issue in #56 (I'm still suspecting some race-condition edge-case in which different versions of the secret are used simultaneously), but OTOH this change won't hurt and might be useful for a number of use cases, anyways. So 👍 from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to use an existing secret for the admin credentials..
This comes in need to fix this issue #56
I'm really sure why is needed, in this comment #51 (comment) you mentioned that if the secret is updated it shouldn't be used until the pods are restarted.