Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: Allow changing transient storage on STS #99

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

LukeHandle
Copy link
Contributor

The deployment allows changing the transient storage - add same functionality to StatefulSet

{{- if .Values.cache.varnishTransientStorage }}
- -varnish-transient-storage={{ .Values.cache.varnishTransientStorage }},{{ .Values.cache.transientStorageSize }}
{{- end }}

Copy link
Member

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, 😖 good catch! 👍

Maybe in the long term, we should think about reducing the code duplication between the Deployment and StatefulSet definitions a bit; bugs like this one are the best indicator for how error-prone this code duplication is... 😕

@martin-helmich martin-helmich added the bug Something isn't working label Sep 7, 2021
@martin-helmich martin-helmich merged commit d34ca55 into mittwald:master Sep 7, 2021
@LukeHandle LukeHandle deleted the patch-1 branch September 7, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants