add ssh secrets #19
Merged
add ssh secrets #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the capability of generating ssh secrets to the secret operator. While implementing this, I also moved the password generation to a different file, which allows for further extension of the operator with additional secret generators. I also moved the test cases to generator specific files. Furthermore, I noticed, that golangs string formatter on the time type is quite verbose. The generated-at annotation now contains a RFC3339 compliant time string.
|
@martin-helmich I've rebased this on the current master. This change is finally ready for review :) |
martin-helmich
requested changes
Apr 6, 2020
martin-helmich
previously requested changes
Apr 7, 2020
elenz97
reviewed
Apr 8, 2020
elenz97
reviewed
Apr 8, 2020
elenz97
dismissed
martin-helmich’s stale review
Dismissing, as all requested changes are outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased on #18 / master
This change adds the capability of generating ssh secrets to the secret
operator.
While implementing this, I also moved the password generation to a
different file, which allows for further extension of the operator with
additional secret generators.
I also moved the test cases to generator specific files.
Furthermore, I noticed, that golangs string formatter on the time type
is quite verbose. The generated-at annotation now contains a
RFC3339 compliant time string.
Since the string generator now also respects the length annotation:
fixes #16