Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #75 #76

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Fixes #75 #76

merged 2 commits into from
Apr 28, 2022

Conversation

u8sand
Copy link
Contributor

@u8sand u8sand commented Mar 28, 2022 •
edited
Loading

When cluster role is disabled, the Role should have permissions to watch for CRDs and create secrets like the ClusterRole.

@mittwald-machine
Copy link
Collaborator

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

martin-helmich
martin-helmich approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies; this should not have gotten stale. LGTM 👍 -- thanks for your contribution. 🙂

@martin-helmich martin-helmich merged commit b6aa929 into mittwald:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-helmich martin-helmich martin-helmich approved these changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@u8sand @mittwald-machine @martin-helmich