Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for timing and clang-tidy use. #30

Merged
merged 2 commits into from
Dec 28, 2019
Merged

Fixes for timing and clang-tidy use. #30

merged 2 commits into from
Dec 28, 2019

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 28, 2019

fixes #28 Timing calculations are wrong
fixes #29 TEST_CASE should evaluate as a statement (no trailing semicolon)

I've added my copyright as a "Portions" bit. If you prefer to instead just have me add a Copyright line below yours (how I do it for my repos), please let me know (or just make the change yourself).

Meaning, I'm also happy with:

 * Copyright (c) 2013-2019 Martin Mitas
 * Copyright 2019 Garrett D'Amore 
 *
 * ... license text follows

Oh, and thanks for your work on this project -- I'm now using it in NNG (as you know), and have begin replacing my own framework (c-convey -- see github.com/gdamore/c-convey) with it as this is simply easier to use and debug.

As an aside, the "(c)" in your copyright statement is actually useless (following a bad practice started by companies years ago who should have known better). Because (c) is not recognized as the copyright symbol, and even if it were, it is entirely redundant to the word "Copyright" in copyright law. (The symbol was intended for uses where a shorthand substitute for the word "Copyright" was desired.)

fixes mity#28 Timing calculations are wrong
fixes mity#29 TEST_CASE should evaluate as a statement (no trailing semicolon)
@mity
Copy link
Owner

mity commented Dec 28, 2019

I've added my copyright as a "Portions" bit. If you prefer to instead just have me add a Copyright line below yours (how I do it for my repos), please let me know (or just make the change yourself).

Yes please. That would be much better.

@gdamore
Copy link
Contributor Author

gdamore commented Dec 28, 2019

I've added my copyright as a "Portions" bit. If you prefer to instead just have me add a Copyright line below yours (how I do it for my repos), please let me know (or just make the change yourself).

Yes please. That would be much better.

Done.

Copy link
Owner

@mity mity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all those. Generally, looks good to me.

I'm just wondering about the CLOCK_MONOTONIC_RAW change little bit, your comment in the issue makes me rather more confused because as far as I remember those two should be same except the adjustments.

include/acutest.h Show resolved Hide resolved
include/acutest.h Show resolved Hide resolved
@mity mity merged commit cb0a262 into mity:master Dec 28, 2019
@mity
Copy link
Owner

mity commented Dec 28, 2019

Merged. Thanks a lot for the fixes and the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TEST_CASE should evaluate as a statement (no trailing semicolon) Timing calculations are wrong
2 participants