Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Do not add feature test macros #7
Here I propose to follow whatever the user wants. This means:
I believe this approach is better than the previous one because if any cutest user does not want to rely on POSIX features we won't enable them and we won't use them. However by default we use them if they are available.
added a commit
this pull request
Feb 23, 2017
Hi @zeehio ,
to be honest, I was thinking quite a lot before I merged the referred #5, because I disliked how the
The current PR makes this even worse in my eyes: It makes quite a hybrid animal from
I would therefore highly prefer if we could unify on strictly following the environment and never setting such macro manually in the header, if that's possible.
Furthermore, as it is implemented, it also seems to change the default run-time behavior in other ways. In particular, not using
So my counter-proposal is as follows (and please let me know if it would satisfy your needs):
Would this work for you?
Your proposal is much better than mine.
I have updated the PR with your instructions, so you don't have to type more if you don't want to. I have given you too much work already.
By the way, I also disabled the
Thanks for your careful thoughts and detailed explanation.