Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash #10

Closed
mity opened this issue Dec 14, 2016 · 1 comment
Closed

Crash #10

mity opened this issue Dec 14, 2016 · 1 comment
Labels
bug

Comments

@mity
Copy link
Owner

mity commented Dec 14, 2016

American Fuzzy Lop has found a crash with a pattern I was able to minimize into this.

[x]:
x
- <?

  x
@mity mity added the bug label Dec 14, 2016
mity added a commit that referenced this issue Dec 14, 2016
@mity
md_enter_child_containers: Fix crash (issue #10).
a725fee 
Calling md_push_container_bytes() may result in ending a current block
which may result in removing some contents from ctx->block_bytes when
removing some lines with link reference definitions.

This in effect means we have to end the block explicitly before storing
the offset into the ctx->block_bytes.
@mity mity closed this as completed Dec 14, 2016
@mity mity mentioned this issue Feb 15, 2017
Closed
@mity mity reopened this May 5, 2019
@mity
Copy link
Owner Author

mity commented May 5, 2019 •
edited
Loading

The above fixed the crash, but we generated bad output:

<ul>
<li><?
<p>x</p>
</li>
</ul>

But the x cannot be a new block. There is no line fulfilling the end-condition for the HTML block started by <?.

Therefore the right output should be

<ul>
<li><?

x
</li>
</ul>

@mity mity closed this as completed in 609dfb0 May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mity