Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~foo~ renders incorrectly #69

Closed
sceutre opened this issue Apr 3, 2019 · 1 comment
Closed

~foo~ renders incorrectly #69

sceutre opened this issue Apr 3, 2019 · 1 comment
Labels

Comments

@sceutre
Copy link

sceutre commented Apr 3, 2019

With strikethrough turned on I see the following:

~`foo`~    // does not wrap foo in <code></code>
~*foo*~    // does not wrap foo in <em></em>
~ `foo`~   // works fine
~ *foo*~   // works fine

Looking at the code, the issue seems to be in md_collect_marks the strikethrough if block does not end in a continue

@mity
Copy link
Owner

mity commented Apr 3, 2019

Confirmed the bug as well as its culprit. Thank you.

For the sake of completeness, if nested in the inverse manner, the problem is there too:

*~foo~*

The only difference is it breaks when handling the closer mark in md_collect_marks().

@mity mity closed this as completed in b858698 Apr 3, 2019
@mity mity added the bug label Apr 3, 2019
ec1oud pushed a commit to ec1oud/md4c that referenced this issue Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants