Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use typedef structs that are compatible with both c and c++ #18

Merged
merged 1 commit into from
Mar 19, 2017

Conversation

aoloe
Copy link
Contributor

@aoloe aoloe commented Mar 19, 2017

the current forward declarations do not work with g++.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.192% when pulling 46dce4b on aoloe:typdef-enum into aeaff18 on mity:master.

@mity
Copy link
Owner

mity commented Mar 19, 2017

Thanks.

The diff itself is ok.

But I noticed the commit belongs to author a.l.e which github does not recognize as belonging to your account. It's not a problem for me, but maybe you might like to fix it before I merge it? If it's not important for you, just let me know and I'll merge as it is.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.192% when pulling 35d33a2 on aoloe:typdef-enum into aeaff18 on mity:master.

@aoloe
Copy link
Contributor Author

aoloe commented Mar 19, 2017

well, the link was not that important... but i took it as a challenge and a/ fixed the gitconfig on this computer b/ discovered how to change the name attached to the last commit!

anyway: thanks for your work on md4c!
i could get a very basic c++ sample that correctly binds the callbacks.
during the next few days, i'll try to make it more c++-alike and -- if you welcome it -- i'll share the samples so that you eventually can use them for the documentation.

@mity
Copy link
Owner

mity commented Mar 19, 2017

;-) Again the e-mail is not recognized.

If you want to fix it, you have either to set to your git config e-mail address already registered with your github account, or alternatively you may add more e-mails in your github account settings. See https://github.com/settings/emails.

@aoloe
Copy link
Contributor Author

aoloe commented Mar 19, 2017

oufh... so much work on a sunday night...

i've now added the other address to github : - )
thanks for the instructions!

@mity mity merged commit 1998090 into mity:master Mar 19, 2017
@mity
Copy link
Owner

mity commented Mar 19, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants