Rework autolinks #220
Merged
Rework autolinks #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 94.23% 94.50% +0.26%
==========================================
Files 3 3
Lines 3123 3147 +24
==========================================
+ Hits 2943 2974 +31
+ Misses 180 173 -7 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mity
force-pushed
the
rework-autolinks
branch
from
e7c2c70
to
f520a6a
Compare
* We have now dedicated run over the inline marks for them. * We check more throughly whether it really looks as an URL or e-mail address. The old implementation recognized even heavily broken ones. * This allows us to be much more careful in order not to cross already resolved marks. * Share substantial parts of the code between all three types of the permissive autolinks (URL, WWW, e-mail). * Merge their tests into one file, spec-permissive-autolinks.txt. * Add one pathological case which triggered quadratic behavior in the old implementation.
mity
force-pushed
the
rework-autolinks
branch
from
f520a6a
to
071f71d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have now dedicated run over the inline marks for them.
We check more throughly whether it really looks as an URL or e-mail
address. The old implementation recognized even heavily broken ones.
This allows us to be much more careful in order not to cross already
resolved marks.
Share substantial parts of the code between all three types of the
permissive autolinks (URL, WWW, e-mail).
Merge their tests into one file,
spec-permissive-autolinks.txt.Add one pathological case which triggered quadratic behavior in the
old implementation.