Use ptrdiff_t for pointer-difference types #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes warnings on msvc in several places: md4c.c(3087): warning C4244: 'function': conversion from '__int64' to 'int', possible loss of data
|
I hope it's portable enough. https://stackoverflow.com/questions/3597743/where-is-ptrdiff-t-defined-in-c We'll find out soon enough on Qt's CI: https://codereview.qt-project.org/c/qt/qtbase/+/534446 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 91.80% 91.81%
=======================================
Files 5 5
Lines 3406 3408 +2
=======================================
+ Hits 3127 3129 +2
Misses 279 279 ☔ View full report in Codecov by Sentry. |
mity
pushed a commit
that referenced
this pull request
Jan 26, 2024
* Use consistently type MD_SIZE for line indeces. * Remove pointer arithmetics if lines and replace it with line index arithmetics. This resolves some warnigns in MSVC builds. See PR #232.
mity
pushed a commit
that referenced
this pull request
Jan 26, 2024
* Use consistently type MD_SIZE for line indeces. * Remove pointer arithmetics if lines and replace it with line index arithmetics. This resolves some warnigns in MSVC builds. See PR #232. Co-authored-by: Shawn Rutledge <s@ecloud.org>
mity
pushed a commit
that referenced
this pull request
Jan 26, 2024
* Use consistently type MD_SIZE for line indeces. * Remove pointer arithmetic if lines and replace it with line index arithmetic. This resolves some warnings in MSVC builds. See PR #232. Co-authored-by: Shawn Rutledge <s@ecloud.org>
mity
added a commit
that referenced
this pull request
Jan 26, 2024
* Use consistently type MD_SIZE for line indeces. * Remove pointer arithmetic if lines and replace it with line index arithmetic. This resolves some warnings in MSVC builds. See PR #232. Co-authored-by: Martin Mitas <mity@morous.org> Co-authored-by: Shawn Rutledge <s@ecloud.org>
|
Thanks for it. However I have to admit I dislike the patch because it now uses I've created an alternative patch based on this, if youre ok with it. See PR #233. |
mity
added a commit
that referenced
this pull request
Jan 26, 2024
* Use consistently type MD_SIZE for line indeces. * Remove pointer arithmetic if lines and replace it with line index arithmetic. This resolves some warnings in MSVC builds. See PR #232. Co-authored-by: Martin Mitas <mity@morous.org> Co-authored-by: Shawn Rutledge <s@ecloud.org>
mity
added a commit
that referenced
this pull request
Jan 26, 2024
* Use consistently type MD_SIZE for line indeces. * Remove pointer arithmetic if lines and replace it with line index arithmetic. This resolves some warnings in MSVC builds. See PR #232. Co-authored-by: Martin Mitas <mity@morous.org> Co-authored-by: Shawn Rutledge <s@ecloud.org>
mity
added a commit
that referenced
this pull request
Jan 26, 2024
* Use consistently type MD_SIZE for line indeces. * Remove pointer arithmetic if lines and replace it with line index arithmetic. This resolves some warnings in MSVC builds. See PR #232. Co-authored-by: Martin Mitas <mity@morous.org> Co-authored-by: Shawn Rutledge <s@ecloud.org>
|
Closing, as the #233 was merged instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes warnings on msvc in several places:
md4c.c(3087): warning C4244: 'function': conversion from '__int64' to 'int', possible loss of data